Fix WithSpan annotation instrumentation #929
Conversation
trask
requested review from
anuraaga,
iNikem,
jkwatson and
tylerbenson
as code owners
| } | ||
|
|
||
| // OpenTelemetry Auto Annotations shaded so that it can be used in opentelemetry-api-beta | ||
| // instrumentation, and then its usage can be unshaded after OpenTelemetry API is shaded |
There was a problem hiding this comment.
Just to confirm this means our unit tests can catch the issue in the future?
There was a problem hiding this comment.
unfortunately, no, this was needed for the fix. currently at least we have to rely on smoke tests to catch shading-related problems. probably we should create a whole smoke test around instrumentation OpenTelemetry API, since that instrumentation is shading-fragile. i will open issue........ (a couple min later) oh ya, i have an issue already for that: #298 😄
| import org.springframework.web.bind.annotation.RequestMapping; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController | ||
| public class WebController { | ||
| @RequestMapping("/greeting") | ||
| public String greeting() { | ||
| return "Sup Dawg"; |
|
I will continue spreading confusion :) First, I don't understand what exactly was broken? Our instrumentation depended and referenced |
It stopped working as soon as The reason it stopped working is because the type of was shaded to call and then |
Resolves #913